Skip to content

[libc] remove strnlen from rtthread.h #6026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2022

Conversation

mysterywolf
Copy link
Member

@mysterywolf mysterywolf commented Jun 3, 2022

remove strnlen from rtthread.h
add __STDC_LIMIT_MACROS macro in Keil
add RT_USING_LIBC in simulator
add _DLIB_ADD_EXTRA_SYMBOLS=0 in IAR

strnlen 不属于ISO/ANSI-C标准库的函数
string.h中部分glibc/POSIX拓展函数各个编译平台不一致
例如strnlen 在IAR中定义 但是keil gcc下没有定义
IAR取消扩展C函数声明
取消strnlen函数在rtthread.h中的定义

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

add __STDC_LIMIT_MACROS macro in Keil
add RT_USING_LIBC in simulator
add _DLIB_ADD_EXTRA_SYMBOLS=0 in IAR
@mysterywolf mysterywolf changed the title [libc] remove strdup from rtthread.h [libc] remove strnlen from rtthread.h Jun 3, 2022
@mysterywolf mysterywolf requested a review from Guozhanxin June 3, 2022 10:31
@BernardXiong BernardXiong merged commit fb3f835 into RT-Thread:master Jun 4, 2022
@mysterywolf mysterywolf deleted the libc3 branch June 4, 2022 20:36
mysterywolf added a commit to mysterywolf/rt-thread that referenced this pull request Jun 5, 2022
mysterywolf added a commit to mysterywolf/rt-thread that referenced this pull request Jun 5, 2022
mysterywolf added a commit to mysterywolf/rt-thread that referenced this pull request Jun 5, 2022
Guozhanxin pushed a commit that referenced this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants